index.php suggestion

Hackay
10 years ago

0

In order to type directly our username, without clicking on the input field, after having loaded the index page ; I suggest to set up a feature.
What do you think about it @flabbyrabbit ?
After having checked the code on GitHub, here is the code to add in the

tag of the index.php page :

Let me know if you’re interested in that, it could be better for the recurring login process.

8replies
4voices
230views

0

Instead of suggesting, you can directly make a request on GitHub.

Hackay
10 years ago

0

I’m going to do it right now, thank you.

Hackay
10 years ago | edited 10 years ago

0

I am completely lost with GitHub. How am I supposed to create a pull request ? I clicked on “new pull request” but then this is a mess…
Anyone could simply show me the way to the edition of the request please ?
Thank you ! :)

PS : I already read that https://help.github.com/articles/using-pull-requests but still lost with the repositories. I need to find the one of index.php (loading page)

singleton
10 years ago

0

You should perform the following steps:

  1. Fork HackThis git repository. It contains all files, including index.php
  2. Clone your own copy of the repository. Use the command ‘git clone http://github.com/hackay/hackthis.co.uk’ (assuming hackay is your username in github.
  3. make the changes locally test, add & commit.
  4. push your changes back to your copy of the repository using ‘git push origin master’.
    By now, if you enter your profile on github and check index.php on your repository, your changes should be visible.
  5. On github, in your copy of hackthis.co.uk repository click on the green button with the arrows on the upper left handside of the screen (tooltip of compare, review, create pull request).
  6. Click on create pull request and then send pull request.

PM me if you need further assistance.

Hackay
10 years ago

0

I’m going to try this. Thank you very much singleton !

Peter [verath]
10 years ago

1

Good suggestion, one note though. The feature you are after is probably better achieved by using the autofocus attribute, instead of relying on javascript. See https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Forms_in_HTML#The_autofocus_attribute.

That said, this seems like a great little thing to do as a first pull request :).

Hackay
10 years ago | edited 10 years ago

0

You’re right auofocus is better in that case :)
But first I have to understad how to make my pull request… @Singleton is going to give me a hand with that :)

Hackay
10 years ago | edited 10 years ago

2

Pull request made, I close.
Big thanks to @singleton and @roun512 !

Discussion thread has been locked. You can no longer add new posts.
1 of 9

This site only uses cookies that are essential for the functionality of this website. Cookies are not used for tracking or marketing purposes.

By using our site, you acknowledge that you have read and understand our Privacy Policy, and Terms of Service.

Dismiss